Do you sometimes feel weird commenting on a more Senior developer merge requests?
 CRIME Shirt $21.68 |
 Tip Your Landlord Shirt $21.68 |
CRIME Shirt $21.68 |
Do you sometimes feel weird commenting on a more Senior developer merge requests?
Do you sometimes feel weird commenting on a more Senior developer merge requests?
CRIME Shirt $21.68 |
Tip Your Landlord Shirt $21.68 |
CRIME Shirt $21.68 |
Yes
The seniors at the company I work at don't get reviewed. They commit the worst shit you've ever seen but they're tight with the team leads so nobody can complain
no why? did you post cringe?
>Unable to read
IQfy at it's finest
You can't imagine. It's hard. And it also sucks that often they see me as a senior.
The senior developers are all moronic. Usually I don't comment on it because I know they're not going to listen to or even understand my feedback.
Don't do it, since I am a senior and don't know shit
No because I got downleveled once at gayman due to “startup” background and “seniors” were moronic.
As a senior dev when I assign a non-trivial PR to someone and I get "looks good, approved." Then I wonder why I even bother. This is one of the few forms of technique sharing and collaboration that we have and you just want to pass it over as an attendance check.
I don't expect you to value any honest opinion I would provide. In fact I expect you to dislike me for it.
Even if you tell me to offer you honest feedback on code reviews, 99% of people who claim to want honest feedback do not, so I will not. Sorry.
I used to do it, but they sperg out as a defense mechanism so now its just lgtm
gotta choose your battles
>Merge requests
lol, lmao
>Pushes to master
>Do you sometimes feel weird commenting on a more Senior developer merge requests?
No and I am not even a developer. "Stop putting private keys in the code repo. This is a security incident. See the incident manager."
no because im not an insecure trainwreck
Yes, and also the juniors
t. moron senior outclassed by his underlings
Don't feel bad, that's how things are supposed to be.
I would never do it.
>What if it introduces a bug?
Not my problem.
Why should I worsen my relationship with the seniors and be seen as a snitch?
Let it fail, and then they will be blamed and I will replace them, while also being the nice non-confrontational guy.
>while also being the nice non-confrontational guy.
a doormat with no spine
doormats always win in the end
guys with spines are at each others throats and at some point this will block you
look at literally every CEO, just a soulless bot following orders
bro you are too black and white for me
I'm not black or white
I'm green
I go through this hell called a job just for money
I literally dgaf about anything else and will do exactly what is required to make more
I don't care about being viewed as having a spine, I don't care about friends, my pride or any of that bullshit
I just want to bury everyone else and come out on top
The minute society forced me to go through this hell is the minute everyone became my sworn enemy
Beware the rage of the NEET forced to work
k
What’s PR? Pull request? Push request? Git? Penis rush?
Penile Rectum. It's a very serious deformity.
code review is an incredible waste of time for most companies.
so much time wasted, and you still probably have bugs out the ass.
people always take it personally, no matter what they say or what the "team culture" is. everyone hates being criticized.
No.
My team lead (company CTO)'s PRs I review just as fierce as everyone else's. I often have the most feedback and change requests on his PRs.
Get in line, fricker. You're one of us. Act like it. We're building quality software over here, and I am NOT going to let you degrade the stability of our software with your hacky workarounds and "quick fixes".
Luckily he appreciates it.
You jr weenies shouldn't feel weird commenting on my reviews. The point of code review is to solicit feedback. What you should be worried about is engaging in futile arguments with my feedback on your reviews. All else equal- and it virtually always is- I'm right and you're wrong. My feedback is best for the long-term health of the project, which it's my job to oversee.